[mypyc] Handle non extention classes with attribute annotations for forward defined classes#18577
Merged
JukkaL merged 1 commit intopython:masterfrom Feb 3, 2025
Merged
Conversation
This PR makes `add_non_ext_class_attr_ann` behave the same way standard python handles modules with `from __future__ import annotations` by using string types. With this we can reference types declared further in the file. But since this will change in future versions of python, let's only do this for forward type references. This also works with string type annotations. Fixes mypyc/mypyc#992
JukkaL
approved these changes
Feb 3, 2025
Collaborator
JukkaL
left a comment
JukkaL
left a comment
There was a problem hiding this comment.
LGTM. This may not solve all potential issues with forward references, but it should cover the most common ones users are likely to hit.
x612skm
pushed a commit
to x612skm/mypy-dev
that referenced
this pull request
Feb 24, 2025
…orward defined classes (python#18577) This PR makes `add_non_ext_class_attr_ann` behave the same way standard python handles modules with `from __future__ import annotations` by using string types. With this we can reference types declared further in the file. But since this will change in future versions of python, let's only do this for forward references, for types that are defined further down in the same module. This also works with string type annotations. Fixes mypyc/mypyc#992
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes
add_non_ext_class_attr_annbehave the same way standard python handles modules withfrom __future__ import annotationsby using string types. With this we can reference types declared further in the file. But since this will change in future versions of python, let's only do this for forward references, for types that are defined further down in the same module.This also works with string type annotations.
Fixes mypyc/mypyc#992