GNU/Hurd returns empty string from getsockname() for AF_UNIX sockets#18630
Merged
JukkaL merged 1 commit intopython:masterfrom Feb 11, 2025
Merged
GNU/Hurd returns empty string from getsockname() for AF_UNIX sockets#18630JukkaL merged 1 commit intopython:masterfrom
JukkaL merged 1 commit intopython:masterfrom
Conversation
Build the socket name from directory name and name instead.
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
JukkaL
approved these changes
Feb 11, 2025
Collaborator
JukkaL
left a comment
JukkaL
left a comment
There was a problem hiding this comment.
I don't have much context on GNU/Hurd, but this seems safe since the new code path won't be used on other platforms.
ericmarkmartin
pushed a commit
to ericmarkmartin/mypy
that referenced
this pull request
Feb 19, 2025
…ython#18630) Build the socket name from directory name and name instead. This fixes existing failing tests on Debian GNU/Hurd: * mypy/test/testdaemon.py::DaemonSuite::* * mypy/test/testipc.py::IPCTests::*
ericmarkmartin
pushed a commit
to ericmarkmartin/mypy
that referenced
this pull request
Feb 19, 2025
…ython#18630) Build the socket name from directory name and name instead. This fixes existing failing tests on Debian GNU/Hurd: * mypy/test/testdaemon.py::DaemonSuite::* * mypy/test/testipc.py::IPCTests::*
x612skm
pushed a commit
to x612skm/mypy-dev
that referenced
this pull request
Feb 24, 2025
…ython#18630) Build the socket name from directory name and name instead. This fixes existing failing tests on Debian GNU/Hurd: * mypy/test/testdaemon.py::DaemonSuite::* * mypy/test/testipc.py::IPCTests::*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build the socket name from directory name and name instead.
This fixes existing failing tests on Debian GNU/Hurd: