Merged
Conversation
cdce8p
force-pushed
the
mypyc-str-rsplit
branch
from
d12e5e2 to
619074f
Compare
cdce8p
force-pushed
the
mypyc-str-rsplit
branch
3 times, most recently
from
fbb6c08 to
6dad3a7
Compare
cdce8p
force-pushed
the
mypyc-str-rsplit
branch
from
6dad3a7 to
b6f0d47
Compare
JukkaL
approved these changes
Feb 14, 2025
Collaborator
JukkaL
left a comment
JukkaL
left a comment
There was a problem hiding this comment.
Nice to have symmetry between split and rsplit!
x612skm
pushed a commit
to x612skm/mypy-dev
that referenced
this pull request
Feb 24, 2025
Use `PyUnicode_RSplit` to optimize `str.rsplit` calls. Although not present in the documentation, it's has actually part of the stable API since Python 3.2. https://github.com/python/cpython/blob/v3.13.2/Doc/data/stable_abi.dat#L799 https://github.com/python/cpython/blob/main/Include/unicodeobject.h#L841-L858
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
PyUnicode_RSplitto optimizestr.rsplitcalls. Although not present in the documentation, it's has actually part of the stable API since Python 3.2.https://github.com/python/cpython/blob/v3.13.2/Doc/data/stable_abi.dat#L799
https://github.com/python/cpython/blob/main/Include/unicodeobject.h#L841-L858