Only defer top-level functions#18718
Merged
ilevkivskyi merged 3 commits intopython:masterfrom Feb 21, 2025
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: steam.py (https://github.com/Gobot1234/steam.py)
- steam/abc.py:667: error: Argument 3 to "_from_proto" of "Review" has incompatible type "PartialUser"; expected "User | ClientUser" [arg-type]
static-frame (https://github.com/static-frame/static-frame)
+ static_frame/core/archive_npy.py:1185: error: Unused "type: ignore" comment [unused-ignore]
spark (https://github.com/apache/spark)
+ python/pyspark/util.py:434: error: Unused "type: ignore" comment [unused-ignore]
+ python/pyspark/util.py:458: error: Unused "type: ignore[misc, operator]" comment [unused-ignore]
+ python/pyspark/pandas/frame.py:6413: error: Argument "value" to "replace" of "Series" has incompatible type "int | float | str | list[Any] | tuple[Any, ...] | dict[Any, Any]"; expected "list[Any] | tuple[Any, ...]" [arg-type]
+ python/pyspark/pandas/namespace.py:2288: error: Unused "type: ignore" comment [unused-ignore]
+ python/pyspark/pandas/namespace.py:2291: error: Unused "type: ignore" comment [unused-ignore]
|
Member
Author
|
The only new error looks correct, as now we apply narrowing from binder ( |
x612skm
pushed a commit
to x612skm/mypy-dev
that referenced
this pull request
Feb 24, 2025
This makes deferral logic more robust and more consistent with fine-grained mode. I also: * Change some terminology, as "top function" is ambiguous: top-level function vs top of stack function. * Update some docs and type annotations to match actual behavior (e.g. we do not defer lambdas) See also python#18674 for some more motivation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes deferral logic more robust and more consistent with fine-grained mode. I also:
See also #18674 for some more motivation.