Fix crash on multiple unpacks in a bare type application#18857
Merged
ilevkivskyi merged 4 commits intopython:masterfrom Mar 31, 2025
Merged
Fix crash on multiple unpacks in a bare type application#18857ilevkivskyi merged 4 commits intopython:masterfrom
ilevkivskyi merged 4 commits intopython:masterfrom
Conversation
…s own anal_type wrapper in a loop
This comment has been minimized.
This comment has been minimized.
ilevkivskyi
approved these changes
Mar 31, 2025
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Closed
jhance
pushed a commit
that referenced
this pull request
May 12, 2025
Fixes #18856. This should be done by `TypeAnalyzer.anal_array` but is not - semanal only invokes its own wrapper around `anal_type` --------- Co-authored-by: Ivan Levkivskyi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18856. This should be done by
TypeAnalyzer.anal_arraybut is not - semanal only invokes its own wrapper aroundanal_type