Fix crash on type inference against non-normal callables#18858
Merged
ilevkivskyi merged 1 commit intopython:masterfrom Mar 31, 2025
Merged
Fix crash on type inference against non-normal callables#18858ilevkivskyi merged 1 commit intopython:masterfrom
ilevkivskyi merged 1 commit intopython:masterfrom
Conversation
sterliakov
approved these changes
Mar 30, 2025
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17755
Fix is trivial, so not really waiting for review. Btw I found few other places where we do not normalize callables. TBH I already forgot when we actually need to normalize, but I don't want to just blanket add normalization, as it may be a relatively expensive function. If we will hit another similar crash, I will add more normalization accordingly (similar to what I did with kwargs unpacking).