Support several more constructs in stubgen's AliasPrinter#18888
Merged
sobolevn merged 3 commits intopython:masterfrom May 19, 2025
Merged
Support several more constructs in stubgen's AliasPrinter#18888sobolevn merged 3 commits intopython:masterfrom
sobolevn merged 3 commits intopython:masterfrom
Conversation
Contributor
|
@cdce8p Can you please take a look? |
Contributor
|
Can we get this merged? |
sobolevn
approved these changes
May 13, 2025
Member
sobolevn
left a comment
sobolevn
left a comment
There was a problem hiding this comment.
Thanks! I will keep this open for a bit, so other can also comment. Ping me in a couple of days.
Collaborator
Author
|
@sobolevn ping as you asked:) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18886. Added implementations for UnaryExpr, SetExpr and SliceExpr, and also fallback to _Incomplete for several other constructs that can sensibly appear in a dataclass field definition.