Docs: added information about deprecated pep 563#18915
Merged
sobolevn merged 2 commits intopython:masterfrom Apr 12, 2025
Merged
Docs: added information about deprecated pep 563#18915sobolevn merged 2 commits intopython:masterfrom
sobolevn merged 2 commits intopython:masterfrom
Conversation
Contributor
Author
|
@sobolevn can please take a look) |
sterliakov
reviewed
Apr 12, 2025
docs/source/runtime_troubles.rst
Outdated
| * Use of string literal types or type comments | ||
| * Use of ``typing.TYPE_CHECKING`` | ||
| * Use of ``from __future__ import annotations`` (:pep:`563`) | ||
| (This directive has been declared deprecated since Python 3.14, and is expected to be removed in a future version of Python) |
Collaborator
There was a problem hiding this comment.
Maybe mention PEP 649 or PEP 749 explicitly here? There were quite a few discussions regarding deferred annotations, I suspect some documentation users may struggle to find the final outcome:)
But also, given that 3.14 is a pre-release, maybe it's better to wait until we actually have 3.14.0 released. While extremely unlikely, things may still change, and this deprecation may get deferred again.
sobolevn
reviewed
Apr 12, 2025
docs/source/runtime_troubles.rst
Outdated
| * Use of string literal types or type comments | ||
| * Use of ``typing.TYPE_CHECKING`` | ||
| * Use of ``from __future__ import annotations`` (:pep:`563`) | ||
| (This directive has been declared deprecated since Python 3.14, and is expected to be removed in a future version of Python) |
Member
There was a problem hiding this comment.
Let's just remove this phrase completely.
Co-authored-by: sobolevn <[email protected]>
sobolevn
approved these changes
Apr 12, 2025
Member
|
In the future we will add notes here about |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced a comment in the documentation that the behavior described in pep 563 might be the default behavior with actual information about what will be declared deprecated in python 3.14