dmypy suggest can now suggest through contextmanager-based decorators#18948
Conversation
asottile
force-pushed
the
mypy-suggest-contextmanager
branch
from
737c5ac to
0db2c46
Compare
asottile
force-pushed
the
mypy-suggest-contextmanager
branch
from
0db2c46 to
f921981
Compare
|
Diff from mypy_primer, showing the effect of this PR on open source code: vision (https://github.com/pytorch/vision)
+ torchvision/utils.py:271: error: Unused "type: ignore" comment [unused-ignore]
|
first commit automated via https://github.com/getsentry/auto-type-annotate - I used these patches to mypy: - python/mypy#18948 - (the line mentioned in the issue commented out): python/mypy#18940 (comment) - and with this unreverted (coming soon!): #89854 <!-- Describe your PR here. -->
first commit automated via https://github.com/getsentry/auto-type-annotate - I used these patches to mypy: - python/mypy#18948 - (the line mentioned in the issue commented out): python/mypy#18940 (comment) - and with this unreverted (coming soon!): #89854 <!-- Describe your PR here. -->
sterliakov
left a comment
sterliakov
left a comment
There was a problem hiding this comment.
Okay, the change looks good, but how come modifying the suggestions engine results in a primer hit? We don't run dmypy suggest with primer...
pretty sure it's a race of another unrelated patch being merged and the use of |
|
I think mypy is nondeterministic on torchvision, see hauntsaninja/mypy_primer#161 mypy_primer uses the merge base on PRs, so the diff should be trustworthy |
hauntsaninja
left a comment
hauntsaninja
left a comment
There was a problem hiding this comment.
Thanks for the fix!
3 participants
No description provided.