Fix dmypy suggest interaction with __new__#18966
Merged
hauntsaninja merged 4 commits intopython:masterfrom Jun 18, 2025
Merged
Conversation
…have `cls` argument
This comment has been minimized.
This comment has been minimized.
A5rocks
approved these changes
Apr 25, 2025
Collaborator
A5rocks
left a comment
A5rocks
left a comment
There was a problem hiding this comment.
This makes sense, is this pattern elsewhere and if so would it make sense to extract it to an @property? (I guess people wouldn't know to use it.)
Collaborator
Author
|
Turns out there are a few places doing such check, so reusing sounds reasonable. Added a doc comment for the attribute with usage guidance. |
This comment has been minimized.
This comment has been minimized.
Collaborator
Author
|
@JukkaL if you're preparing the next release, can this PR sneak in? It only fixes a crash in |
hauntsaninja
approved these changes
Jun 18, 2025
hauntsaninja
force-pushed
the
bugfix/gh-18964-dmypy-suggest-dunder-new
branch
from
52dedc3 to
dcbb0d2
Compare
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18964.
__new__is special - it hasis_staticset insemanal.py, but still has firstclsargument. This PR tellsdmypy suggestabout that.