Check superclass compatibility of untyped methods if --check-untyped-defs is set#18970
Merged
JukkaL merged 3 commits intopython:masterfrom May 1, 2025
Merged
Conversation
Collaborator
Author
|
...thank you, github, for detecting some random person's username in my commit messages. Sorry for this ping:( |
This comment has been minimized.
This comment has been minimized.
Collaborator
Author
|
All primer hits are good: new errors are coming from projects with |
sterliakov
changed the title
--check-untyped-defs is set
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: pytest-robotframework (https://github.com/detachhead/pytest-robotframework)
- pytest_robotframework/_internal/pytest/robot_file_support.py:64: error: Method "collect" is marked as an override, but no base method was found with this name [misc]
- pytest_robotframework/_internal/pytest/robot_file_support.py:167: error: Method "reportinfo" is marked as an override, but no base method was found with this name [misc]
- pytest_robotframework/_internal/pytest/robot_file_support.py:171: error: Method "repr_failure" is marked as an override, but no base method was found with this name [misc]
- pytest_robotframework/_internal/pytest/robot_file_support.py:192: error: Method "toterminal" is marked as an override, but no base method was found with this name [misc]
- pytest_robotframework/__init__.py:95: error: Method "_get_failure" is marked as an override, but no base method was found with this name [misc]
- pytest_robotframework/_internal/robot/listeners_and_suite_visitors.py:107: error: Method "parse" is marked as an override, but no base method was found with this name [misc]
- pytest_robotframework/_internal/robot/listeners_and_suite_visitors.py:193: error: Method "parse_init" is marked as an override, but no base method was found with this name [misc]
- pytest_robotframework/_internal/robot/listeners_and_suite_visitors.py:217: error: Method "start_suite" is marked as an override, but no base method was found with this name [misc]
- pytest_robotframework/_internal/robot/listeners_and_suite_visitors.py:226: error: Method "end_suite" is marked as an override, but no base method was found with this name [misc]
- pytest_robotframework/_internal/robot/listeners_and_suite_visitors.py:249: error: Method "visit_test" is marked as an override, but no base method was found with this name [misc]
- pytest_robotframework/_internal/robot/listeners_and_suite_visitors.py:260: error: Method "end_suite" is marked as an override, but no base method was found with this name [misc]
- pytest_robotframework/_internal/robot/listeners_and_suite_visitors.py:303: error: Method "start_test" is marked as an override, but no base method was found with this name [misc]
- pytest_robotframework/_internal/robot/listeners_and_suite_visitors.py:330: error: Method "start_suite" is marked as an override, but no base method was found with this name [misc]
- pytest_robotframework/_internal/robot/listeners_and_suite_visitors.py:403: error: Method "start_test" is marked as an override, but no base method was found with this name [misc]
- pytest_robotframework/_internal/robot/listeners_and_suite_visitors.py:493: error: Method "end_test" is marked as an override, but no base method was found with this name [misc]
- pytest_robotframework/_internal/robot/listeners_and_suite_visitors.py:530: error: Method "start_test" is marked as an override, but no base method was found with this name [misc]
- pytest_robotframework/_internal/robot/listeners_and_suite_visitors.py:539: error: Method "end_test" is marked as an override, but no base method was found with this name [misc]
- pytest_robotframework/_internal/robot/listeners_and_suite_visitors.py:548: error: Method "log_message" is marked as an override, but no base method was found with this name [misc]
- pytest_robotframework/_internal/robot/listeners_and_suite_visitors.py:575: error: Method "start_test" is marked as an override, but no base method was found with this name [misc]
- pytest_robotframework/_internal/robot/listeners_and_suite_visitors.py:579: error: Method "log_message" is marked as an override, but no base method was found with this name [misc]
- pytest_robotframework/_internal/robot/listeners_and_suite_visitors.py:586: error: Method "end_test" is marked as an override, but no base method was found with this name [misc]
- pytest_robotframework/_internal/robot/listeners_and_suite_visitors.py:660: error: Method "start_library_keyword" is marked as an override, but no base method was found with this name [misc]
psycopg (https://github.com/psycopg/psycopg)
+ tests/scripts/spiketest.py:108: error: Signature of "connect" incompatible with supertype "Connection" [override]
+ tests/scripts/spiketest.py:108: note: Superclass:
+ tests/scripts/spiketest.py:108: note: @classmethod
+ tests/scripts/spiketest.py:108: note: def connect(cls, conninfo: str = ..., *, autocommit: bool = ..., prepare_threshold: int | None = ..., context: AdaptContext | None = ..., row_factory: RowFactory[Row] | None = ..., cursor_factory: type[Cursor[Row]] | None = ..., **kwargs: str | int | None) -> DelayedConnection[Row]
+ tests/scripts/spiketest.py:108: note: Subclass:
+ tests/scripts/spiketest.py:108: note: @classmethod
+ tests/scripts/spiketest.py:108: note: def connect(cls, conninfo: Any, conn_delay: Any = ..., **kwargs: Any) -> Any
pandas (https://github.com/pandas-dev/pandas)
+ pandas/_testing/__init__.py:352: error: Cannot override writeable attribute with read-only property [override]
streamlit (https://github.com/streamlit/streamlit)
+ lib/tests/streamlit/watcher/test_data/misbehaved_module.py: note: In class "_MisbehavedModule":
+ lib/tests/streamlit/watcher/test_data/misbehaved_module.py:20:5: error: Cannot override writeable attribute with read-only property [override]
tornado (https://github.com/tornadoweb/tornado)
+ tornado/test/auth_test.py:78: error: Signature of "_oauth_get_user_future" incompatible with supertype "OAuthMixin" [override]
+ tornado/test/auth_test.py:78: note: Superclass:
+ tornado/test/auth_test.py:78: note: def _oauth_get_user_future(self, access_token: dict[str, Any]) -> Coroutine[Any, Any, dict[str, Any]]
+ tornado/test/auth_test.py:78: note: Subclass:
+ tornado/test/auth_test.py:78: note: def _oauth_get_user_future(*Any, **Any) -> Future[Any]
+ tornado/test/web_test.py:1539: error: Signature of "make_static_url" incompatible with supertype "StaticFileHandler" [override]
+ tornado/test/web_test.py:1539: note: Superclass:
+ tornado/test/web_test.py:1539: note: @classmethod
+ tornado/test/web_test.py:1539: note: def make_static_url(cls, settings: dict[str, Any], path: str, include_version: bool = ...) -> str
+ tornado/test/web_test.py:1539: note: Subclass:
+ tornado/test/web_test.py:1539: note: @classmethod
+ tornado/test/web_test.py:1539: note: def make_static_url(cls, settings: Any, path: Any) -> Any
+ tornado/test/web_test.py:1539: note: Superclass:
+ tornado/test/web_test.py:1539: note: @classmethod
+ tornado/test/web_test.py:1539: note: def make_static_url(cls, settings: dict[str, Any], path: str, include_version: bool = ...) -> str
+ tornado/test/web_test.py:1539: note: Subclass:
+ tornado/test/web_test.py:1539: note: @classmethod
+ tornado/test/web_test.py:1539: note: def make_static_url(cls, settings: Any, path: Any) -> Any
mitmproxy (https://github.com/mitmproxy/mitmproxy)
+ mitmproxy/contentviews/_view_socketio.py:27: error: Cannot override writeable attribute with read-only property [override]
+ mitmproxy/contentviews/_view_socketio.py:45: error: Cannot override writeable attribute with read-only property [override]
+ mitmproxy/tools/console/overlay.py:20: error: Cannot override writeable attribute with read-only property [override]
pytest (https://github.com/pytest-dev/pytest)
+ testing/test_collection.py:1618: error: Signature of "from_parent" incompatible with supertype "Class" [override]
+ testing/test_collection.py:1618: note: Superclass:
+ testing/test_collection.py:1618: note: @classmethod
+ testing/test_collection.py:1618: note: def from_parent(cls, parent: Any, *, name: Any, obj: Any = ..., **kw: Any) -> MyCollector
+ testing/test_collection.py:1618: note: Subclass:
+ testing/test_collection.py:1618: note: @classmethod
+ testing/test_collection.py:1618: note: def from_parent(cls, parent: Any, *, name: Any, x: Any) -> Any
+ testing/test_collection.py:1618: error: Signature of "from_parent" incompatible with supertype "Node" [override]
+ testing/test_collection.py:1618: note: Superclass:
+ testing/test_collection.py:1618: note: @classmethod
+ testing/test_collection.py:1618: note: def from_parent(cls, parent: Node, **kw: Any) -> MyCollector
+ testing/test_collection.py:1618: note: Subclass:
+ testing/test_collection.py:1618: note: @classmethod
+ testing/test_collection.py:1618: note: def from_parent(cls, parent: Any, *, name: Any, x: Any) -> Any
zulip (https://github.com/zulip/zulip)
- tools/documentation_crawler/documentation_crawler/commands/crawl_with_status.py:11: error: Method "run" is marked as an override, but no base method was found with this name [misc]
- zerver/lib/db.py:38: error: Method "execute" is marked as an override, but no base method was found with this name [misc]
- zerver/lib/db.py:42: error: Method "executemany" is marked as an override, but no base method was found with this name [misc]
- tools/documentation_crawler/documentation_crawler/spiders/common/spiders.py:209: error: Method "start_requests" is marked as an override, but no base method was found with this name [misc]
- tools/documentation_crawler/documentation_crawler/spiders/common/spiders.py:214: error: Method "parse" is marked as an override, but no base method was found with this name [misc]
- zerver/lib/sqlalchemy_utils.py:16: error: Method "status" is marked as an override, but no base method was found with this name [misc]
- zerver/tornado/handlers.py:96: error: Method "initialize" is marked as an override, but no base method was found with this name [misc]
- zerver/tornado/handlers.py:110: error: Method "on_finish" is marked as an override, but no base method was found with this name [misc]
- zerver/tornado/handlers.py:175: error: Method "get" is marked as an override, but no base method was found with this name [misc]
- zerver/tornado/handlers.py:209: error: Method "post" is marked as an override, but no base method was found with this name [misc]
- zerver/tornado/handlers.py:213: error: Method "delete" is marked as an override, but no base method was found with this name [misc]
- zerver/tornado/handlers.py:217: error: Method "on_connection_close" is marked as an override, but no base method was found with this name [misc]
- zproject/backends.py:2091: error: Method "auth_complete" is marked as an override, but no base method was found with this name [misc]
- zproject/backends.py:2206: error: Method "user_data" is marked as an override, but no base method was found with this name [misc]
- zproject/backends.py:2340: error: Method "get_or_create_state" is marked as an override, but no base method was found with this name [misc]
- zproject/backends.py:2376: error: Method "validate_state" is marked as an override, but no base method was found with this name [misc]
- zproject/backends.py:2402: error: Method "get_user_details" is marked as an override, but no base method was found with this name [misc]
- zproject/backends.py:2478: error: Method "get_user_details" is marked as an override, but no base method was found with this name [misc]
- zproject/backends.py:2683: error: Method "get_idp" is marked as an override, but no base method was found with this name [misc]
- zproject/backends.py:2690: error: Method "auth_url" is marked as an override, but no base method was found with this name [misc]
- zproject/backends.py:2780: error: Method "_check_entitlements" is marked as an override, but no base method was found with this name [misc]
- zproject/backends.py:3124: error: Method "get_key_and_secret" is marked as an override, but no base method was found with this name [misc]
- zerver/tests/test_outgoing_http.py:17: error: Method "_on_request" is marked as an override, but no base method was found with this name [misc]
- zerver/tests/test_outgoing_http.py:36: error: Method "_on_request" is marked as an override, but no base method was found with this name [misc]
pyodide (https://github.com/pyodide/pyodide)
+ src/py/pyodide/console.py:50: error: Cannot override writeable attribute with read-only property [override]
+ src/py/pyodide/console.py:54: error: Cannot override writeable attribute with read-only property [override]
|
JukkaL
approved these changes
May 1, 2025
Collaborator
JukkaL
left a comment
JukkaL
left a comment
There was a problem hiding this comment.
Thanks for the PR! I agree that the new behavior seems more consistent, and it doesn't seem to cause a huge number of new errors, so we don't need to consider this as a backward compatibility break.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables superclass compatibility checks for untyped methods when
--check-untyped-defsis set. IMO this behavior is correct as--check-untyped-defsis essentially "treat everything as if there were: Anyannotations on all arguments", hence checking arg count and names is sound.This PR, however, allows
@overrideon classes that have Any fallback as those are often coming from unfollowed imports. This PR started as an attempt to reject@overrideon untyped defs not found in superclass, but I think it's better to just run all compatibility checks if the flag is enabled.