Emit a friendlier warning on invalid exclude regex, instead of a stacktrace#19102
Merged
JelleZijlstra merged 3 commits intopython:masterfrom May 19, 2025
Merged
Emit a friendlier warning on invalid exclude regex, instead of a stacktrace#19102JelleZijlstra merged 3 commits intopython:masterfrom
JelleZijlstra merged 3 commits intopython:masterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
based on Jelle's review, I realized that mypy is pretty consistent about sending usage errors to stderr, and so I have fixed both my code and the code I modelled by code after to do that instead
JelleZijlstra
approved these changes
May 19, 2025
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an invalid exclude is used, the error message
now looks like this: