Fix nondeterministic type checking by making join between TypeType and TypeVar commute#19149
Merged
JukkaL merged 1 commit intopython:masterfrom May 27, 2025
Merged
Conversation
hauntsaninja
changed the title
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
A5rocks
approved these changes
May 26, 2025
Collaborator
A5rocks
left a comment
A5rocks
left a comment
There was a problem hiding this comment.
At some point I was trying to get some basic property testing setup which could eliminate this class of bugs, but it ended up too complicated :(
This makes sense though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18125
Unhandled cases in
defaultseem fairly dangerous