Update Fix help message url for "None and Optional handling" section#19252
Merged
hauntsaninja merged 1 commit intopython:masterfrom Jun 8, 2025
Merged
Update Fix help message url for "None and Optional handling" section#19252hauntsaninja merged 1 commit intopython:masterfrom
hauntsaninja merged 1 commit intopython:masterfrom
Conversation
Collaborator
|
Maybe it makes more sense to update the docs to support this old anchor, for people on older mypy versions? |
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
hauntsaninja
approved these changes
Jun 8, 2025
Collaborator
hauntsaninja
left a comment
hauntsaninja
left a comment
There was a problem hiding this comment.
Thanks for spotting and fixing! (Open to A5rocks idea in addition!)
wyattscarpenter
added a commit
to wyattscarpenter/mypy
that referenced
this pull request
Sep 11, 2025
Not sure if this will work, since something else has the same anchor on a different page... See python#19252, though.
hauntsaninja
pushed a commit
that referenced
this pull request
Nov 2, 2025
…19828) Addresses #19252 (comment) > support this old anchor, for people on older mypy versions This way, when people get the old documentation link, it will continue to go to the right place. I have looked at the documentation that gets generated locally to see if everything still works. It does. In our vast panoply of documentation, we now have two very similar refs, `no-strict-optional` and `no_strict_optional` (used in https://mypy.readthedocs.io/en/stable/common_issues.html#no-errors-reported-for-obviously-wrong-code to link to https://mypy.readthedocs.io/en/stable/command_line.html#no-strict-optional) but the software handles them fine, without getting confused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19251
Correct url in help message"None and Optional handling" group
Checklist:
Add tests for all changed behaviour.