[mypyc] Make generated generator helper method internal#19268
Merged
Conversation
Add a flag to FuncIR to allow functions to be marked as internal. Don't generate wrapper functions/methods that allow calls from Python for internal methods, since these are internal implementation details. This has these benefits: * Internal functions are private and don't pollute public namespaces. * Signatures of generated functions can use arbitrary C types (e.g. arbitrary pointer types), even those that can't be passed to/from Python. * We generate less C code (fewer wrapper functions).
svalentin
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a flag to FuncIR to allow functions to be marked as internal. Don't generate wrapper functions/methods that allow calls from Python for internal methods, since these are internal implementation details.
This has these benefits: