Fix TypeGuard/TypeIs being forgotten when semanal defers#19325
Merged
hauntsaninja merged 1 commit intopython:masterfrom Jun 22, 2025
Merged
Fix TypeGuard/TypeIs being forgotten when semanal defers#19325hauntsaninja merged 1 commit intopython:masterfrom
TypeGuard/TypeIs being forgotten when semanal defers#19325hauntsaninja merged 1 commit intopython:masterfrom
Conversation
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
hauntsaninja
approved these changes
Jun 22, 2025
Collaborator
hauntsaninja
left a comment
hauntsaninja
left a comment
There was a problem hiding this comment.
Nice fix, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19318
Don't re-analyze
type_is/type_guardif the callable's type was successfully analyzed on a previous semanal pass. After the first successful pass, the return type will have been replaced bybuiltins.bool, so subsequent analysis can't detectType{Guard,Is}.