[mypyc] Simplify comparison of tuple elements#19396
Merged
JukkaL merged 1 commit intopython:masterfrom Jul 8, 2025
Merged
Conversation
Collaborator
|
I measured the impact to mypy self check runtime using |
Collaborator
I did another measurement and it appears to be random noise, unfortunately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Got rid of unnecessary operations when comparing tuple elements returns a bit primitive.
Example code:
IR before:
IR after:
Tested using the following benchmark:
Execution time goes from ~315ms to ~150ms on my machine.