Conversation
Avoid using lambdas in the most expensive hooks, since they are slower than direct method calls. Also use `if hook is None` checks instead of `if hook`, since the prior is more efficient when compiled. I used trace logging to look for generic/unoptimized function calls, and it was clear that ChainedPlugin was doing many unoptimized calls that were easy to avoid. This is a part of a set of micro-optimizations that improve self check performance by ~5.5%.
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
sterliakov
approved these changes
Jul 16, 2025
Collaborator
sterliakov
left a comment
sterliakov
left a comment
There was a problem hiding this comment.
I expected that get_function_hook is similarly hot too, that probably depends on the codebase (more of OOP of more of a functional style). Would it make sense to inline it too?
Collaborator
Author
It didn't come up much in my use case, but it's true that it could be a bottleneck in other use cases. I'll do it in a follow-up PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid using lambdas in the most expensive hooks, since they are slower than direct method calls. Also use
if hook is Nonechecks instead ofif hook, since the prior is more efficient when compiled.I used trace logging to look for generic/unoptimized function calls, and it was clear that ChainedPlugin was doing many unoptimized calls that were easy to avoid.
This duplicates some code, but I think it's fine since this code is updated very rarely but the code paths are very hot.
This is a part of a set of micro-optimizations that improve self check performance by ~5.5%.