Fix #19507 Prevent final reassignment in match case#19496
Merged
hauntsaninja merged 1 commit intopython:masterfrom Jul 27, 2025
Merged
Fix #19507 Prevent final reassignment in match case#19496hauntsaninja merged 1 commit intopython:masterfrom
hauntsaninja merged 1 commit intopython:masterfrom
Conversation
omerhadari
force-pushed
the
prevent-final-reassignment-in-match-case
branch
2 times, most recently
from
5378cb1 to
421adbe
Compare
This comment has been minimized.
This comment has been minimized.
omerhadari
force-pushed
the
prevent-final-reassignment-in-match-case
branch
from
421adbe to
7b6ad2d
Compare
omerhadari
force-pushed
the
prevent-final-reassignment-in-match-case
branch
from
7b6ad2d to
e2c9e6b
Compare
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
omerhadari
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19507
This PR adds a check to prevent reassignment of final variables in a match statement.
Currently, the following passes without an error:
MyPy already checks that the type of FOO isn't changed if used like this. I added a check in the same place that makes sure it's not
Finaleither.Since this tests the match syntax, I put the test where I did. If it's not the appropriate place for it I will move it as instructed :)