Skip to content

[mypyc] feat: optimize f-string building from Final values#19611

Merged
JukkaL merged 35 commits intopython:masterfrom
BobTheBuidler:patch-3
Aug 15, 2025
Merged

[mypyc] feat: optimize f-string building from Final values#19611
JukkaL merged 35 commits intopython:masterfrom
BobTheBuidler:patch-3

Conversation

@BobTheBuidler
Copy link
Contributor

@BobTheBuidler BobTheBuidler commented Aug 7, 2025 •
edited
Loading

We can do some extra constant folding in cases like this:

from typing import Final

BASE_URL: Final = "https://example.com"
PORT: Final = 1234

def get_url(endpoint: str) -> str:
    return f"{BASE_URL}:{PORT}/{endpoint}"

which should generate the same C code as

def get_url(endpoint: str) -> str:
    return f"https://example.com:1234/{endpoint}"

This PR makes it so.

@BobTheBuidler BobTheBuidler changed the title WIP [mypyc] optimize f-string building [mypyc] feat: optimize f-string building from Final values Aug 11, 2025
@BobTheBuidler BobTheBuidler marked this pull request as ready for review August 11, 2025 22:05
@BobTheBuidler
Copy link
Contributor Author

BobTheBuidler commented Aug 11, 2025

This PR is now ready for review.

@BobTheBuidler
Copy link
Contributor Author

BobTheBuidler commented Aug 11, 2025 •
edited
Loading

This can probably be extended later on for non-final values that type check as Literals ex:

def test():
    abcd = "abcd"
    efgh = "efgh"
    if some_check():
        ijkl = "ijkl0"
        some_numbers = 123
        return f"{abcd}{efgh}{ijkl}{some_numbers}{some_fn()}"
    else:
        ijkl = "ijkl1"
        some_numbers = 456
        return f"{abcd}{efgh}{ijkl}{some_numbers}{some_fn()}"

But I think that goes beyond the scope of this PR. Once we merge this it will be easy to modify the literal helper fn.

JukkaL
JukkaL reviewed Aug 13, 2025
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! The approach looks good, just a few minor comments.

@BobTheBuidler
Copy link
Contributor Author

BobTheBuidler commented Aug 13, 2025

Thanks for your feedbacks. Tests added, comment removed.

@JukkaL JukkaL merged commit ac646c0 into python:master Aug 15, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JukkaL JukkaL JukkaL approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BobTheBuidler @JukkaL