Fix crash on settable property alias#19615
Merged
ilevkivskyi merged 3 commits intopython:masterfrom Aug 8, 2025
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
sterliakov
approved these changes
Aug 8, 2025
Collaborator
|
Primer output isn't obviously correct this time:
|
Co-authored-by: Stanislav Terliakov <[email protected]>
Member
Author
|
@sterliakov the |
This comment has been minimized.
This comment has been minimized.
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: prefect (https://github.com/PrefectHQ/prefect)
+ src/prefect/blocks/core.py:1079: note: "load" of "Block" defined here
+ src/prefect/results.py:104: note: "get_default_result_storage" defined here
+ src/prefect/results.py:166: note: "resolve_result_storage" defined here
+ src/prefect/results.py:472: note: "_exists" of "ResultStore" defined here
+ src/prefect/results.py:551: note: "_read" of "ResultStore" defined here
+ src/prefect/results.py:745: note: "_persist_result_record" of "ResultStore" defined here
+ src/prefect/blocks/core.py:1177: note: "load_from_ref" of "Block" defined here
+ src/prefect/deployments/runner.py:992: note: "from_storage" of "RunnerDeployment" defined here
+ src/prefect/results.py:166: note: "resolve_result_storage" defined here
+ src/prefect/results.py:374: note: "update_for_flow" of "ResultStore" defined here
+ src/prefect/results.py:398: note: "update_for_task" of "ResultStore" defined here
+ src/prefect/artifacts.py:84: note: "create" of "Artifact" defined here
+ src/prefect/artifacts.py:151: note: "get" of "Artifact" defined here
+ src/prefect/artifacts.py:248: note: "format" of "Artifact" defined here
+ src/prefect/artifacts.py:334: note: "format" of "ProgressArtifact" defined here
- src/prefect/testing/fixtures.py:424: note: def process_events(dequeue_events: bool = ..., min_events: int = ..., timeout: int = ...) -> Union[R?, Coroutine[Any, Any, R?]]
+ src/prefect/testing/fixtures.py:424: note: def process_events(self, dequeue_events: bool = ..., min_events: int = ..., timeout: int = ...) -> Union[R?, Coroutine[Any, Any, R?]]
|
sterliakov
approved these changes
Aug 8, 2025
Collaborator
sterliakov
left a comment
sterliakov
left a comment
There was a problem hiding this comment.
All good now, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19572
Surprisingly, when working on this I found another inconsistency in how
.definitonis set. So after all I decided to do some cleanup, now.definitonshould always point do theDecortorif the definition is a decorated function (no matter whether it is a trivial decorator like@abstractmethodor@overloador a "real" one).