Do not use outer context for or expr inference if the LHS has Any#19748
Merged
ilevkivskyi merged 1 commit intopython:masterfrom Aug 28, 2025
Merged
Do not use outer context for or expr inference if the LHS has Any#19748ilevkivskyi merged 1 commit intopython:masterfrom
or expr inference if the LHS has Any#19748ilevkivskyi merged 1 commit intopython:masterfrom
Conversation
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: discord.py (https://github.com/Rapptz/discord.py)
+ discord/activity.py:416: error: Incompatible types in assignment (expression has type "Any | dict[Any, Any]", variable has type "ActivityAssets") [assignment]
|
ilevkivskyi
approved these changes
Aug 28, 2025
Member
ilevkivskyi
left a comment
ilevkivskyi
left a comment
There was a problem hiding this comment.
Any-related logic w.r.t. inference is already quite ad-hoc, so TBH this doesn't make it much worse.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19492.
In #19695 I tried to add another set of heuristics to
any_constraints, but can't get that working: trying to join/meet all similar constraints together breaks inference in other cases, and only doing that for Any would be somewhat non-trivial. This PR reverts behaviour introduced in #19492 when LHS of the expression containsAny. Outer context is still included in all other cases, and this seems to strike a good balance.