Conversation
This comment has been minimized.
This comment has been minimized.
Member
|
@hauntsaninja That will be still slower because the only way you can an "unknown" |
Collaborator
|
yes it'll be slower, but should be much faster than allocating a new function object while keeping things more readable. don't feel strongly though and i didn't measure |
ilevkivskyi
approved these changes
Sep 1, 2025
mypy/meet.py
Outdated
| if is_subtype(left, right, ignore_promotions=ignore_promotions) or is_subtype( | ||
| right, left, ignore_promotions=ignore_promotions | ||
| ): | ||
| return True |
Member
There was a problem hiding this comment.
One possible way to de-uglify this is to move this whole chunk to a new function outside (say overlap_simple()), and re-use it below. This way it will at least not appear twice.
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several mypy micro-optimizations. Together with batches 1 and 2 these improve self check performance by 1.8%.
This mostly avoids some allocations of nested function objects.