[mypyc] feat: optimize away first if-check in for_loop_helper_with_index#19933
Merged
JukkaL merged 3 commits intopython:masterfrom Sep 29, 2025
Merged
[mypyc] feat: optimize away first if-check in for_loop_helper_with_index#19933JukkaL merged 3 commits intopython:masterfrom
for_loop_helper_with_index#19933JukkaL merged 3 commits intopython:masterfrom
Conversation
BobTheBuidler
changed the title
for_loop_helper_with_indexfor_loop_helper_with_index
JukkaL
approved these changes
Sep 29, 2025
Collaborator
JukkaL
left a comment
JukkaL
left a comment
There was a problem hiding this comment.
Makes sense. The C compiler may be able to perform a similar optimization in some cases, but not necessarily in every case where we can do it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is not necessary to enter the gen_condition block on the first iteration, we can safely skip it. This won't be particularly impactful but its a low-hanging fruit.