Use dummy concrete type instead of Any when checking protocol variance#20110
Merged
ilevkivskyi merged 1 commit intopython:masterfrom Oct 27, 2025
Merged
Use dummy concrete type instead of Any when checking protocol variance#20110ilevkivskyi merged 1 commit intopython:masterfrom
Any when checking protocol variance#20110ilevkivskyi merged 1 commit intopython:masterfrom
Conversation
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
sterliakov
approved these changes
Oct 24, 2025
Collaborator
sterliakov
left a comment
There was a problem hiding this comment.
Makes sense, thanks!
ilevkivskyi
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20108.
Variance checks for protocols follow a procedure roughly equivalent to that described in typing.python.org - Variance Inference. A major difference in mypy's current implementation is in Step 3:
Mypy currently uses
Anyrather than a concrete dummy type. This causes issues during overload subtype checks in the example reported in the original issue, as the specialisations when checking variance suitability of_T2_contralook like:This PR replaces the use of
Anywith a dummy concrete type in the entire protocol variance check to more closely follow the variance inference algorithm in the spec and fixes this overload issue.