Add a regression test for #15979, and fix linecount-report for Windows#20111
Add a regression test for #15979, and fix linecount-report for Windows#20111ilevkivskyi merged 4 commits intopython:masterfrom
Conversation
python#16019, which fixed this issue (for linux) was not accompanied by a regression test
wyattscarpenter
changed the title
for more information, see https://pre-commit.ci
wyattscarpenter
changed the title
This comment has been minimized.
This comment has been minimized.
sterliakov
left a comment
sterliakov
left a comment
There was a problem hiding this comment.
This has a TOCTOU problem, but I think that's fine, report generation is anyway not robust enough to support concurrent file modifications. Thanks!
|
I considered this TOCTOU problem, but I don't think there's a better way around it. I'm sure by the time someone files a bug report to complain about a crash caused by them replacing one of their files with a directory in the middle of report generation, python will have fixed its file-access bug :^) |
emmatyping
left a comment
emmatyping
left a comment
There was a problem hiding this comment.
Thanks! I think this looks good.
|
Oh and
yeah I don't think there's much to be done here |
|
Hopefully a big red "crash" label will help this set of PRs make it to the nearest release:) |
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
4 participants
#16019, which fixed this issue (for linux) was not accompanied by a regression test. Thus, nobody noticed that it doesn't work on Windows!
This fixes an Internal Error where namespace packages were not supported properly. This fix was inspired by @sterliakov noticing that #18128 was very similar to #19843, which has a similar fix. Note that we use
os.path.isdir(tree.path)instead of trying to catch anIsADirectoryErrorexception because of a bug on Windows which causes it to throw aPermissionErrorinstead in the relevant situation, which makesexcept IsADirectoryErrorunreliable. (We also can't justexcept (IsADirectoryError, PermissionError)because what if there is an actual permission error?)