Conversation
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Member
|
Btw the same test fails on master. So it is not your PR, likely this fix is incomplete however. |
Collaborator
Author
|
I'll merge this for now and investigate the failure afterwards. |
Member
|
@JukkaL just in case it will be helpful, a while ago when I had a similar problem I added this https://github.com/python/mypy/blob/master/test-data/unit/lib-stub/typing_extensions.pyi#L1-L3 IIRC the problem was caused by how we resolve stdlib modules when we run our tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a file uses t-strings, implicitly depend on
string.templatelib.Also improve test coverage a bit.
Follow-up to #20850.