Conversation
AA-Turner
force-pushed
the
sphinx-pep-zero
branch
3 times, most recently
from
5faec5d to
1439cad
Compare
|
This also needs rebasing |
AA-Turner
force-pushed
the
sphinx-pep-zero
branch
from
1439cad to
0dfccf0
Compare
|
Rebased |
|
Moar rebasing 😉 |
|
yup, one sec |
AA-Turner
force-pushed
the
sphinx-pep-zero
branch
from
0dfccf0 to
835adfc
Compare
|
rebased take 2 |
|
Can you give me some context on why we need the authors override file? I have a guess but I would like to know the extent of the problem and why is needed now and not before. |
as authors names were parsed wrong / duplicates missed (currently on /dev/python/) prev discussion: why not before - no idea, but I like to leave things better than I found them |
I assume https://github.com/python/peps/pull/1386/files is included here no? |
yes |
|
Will make another pass tomorrow :) |
|
@pablogsal done, and fixed that I accidentally left out the hook into the Sphinx build process! Apart from that some refactoring for ease of reading / future maintenence - the PEP 0 generation was the area I hadn't touched much as slightly scared to break it! |
AA-Turner
force-pushed
the
sphinx-pep-zero
branch
from
471ba58 to
4cb6e8c
Compare
|
Left one comment, otherwise looks good to me |
3 participants
See #2, #1385 for context. Superseeds #1567.
This is the PEP 0 generation part, building on PR #1930. It contains the logic for parsing all PEPs and building the PEP index:
PEP-0000.rstfileNote that this PR also contains elements from PR #1386.