Merged
Conversation
Closed
matrixise
reviewed
May 5, 2021
AA-Turner
force-pushed
the
sphinx-rss
branch
2 times, most recently
from
a82ddc8 to
c46ce31
Compare
Member
|
@AA-Turner This needs rebasing or closing? |
Member
Author
|
Rebased |
Member
|
@AA-Turner What's the best way to test this? |
Member
Author
|
|
Member
Author
|
Just found https://validator.w3.org/feed/#validate_by_input, seems that the spec only supports one author entry per item, will ammend. (edit: for future ref, https://stackoverflow.com/questions/5855993/multiple-authors-in-rss-or-atoms) |
Member
Author
|
@pablogsal fixed author issues (W3C validator not entirely happy as it expects only one author, but the spec is silent on this and the SO answer above seemed to confirm that there is no best way to deal with this). |
pablogsal
approved these changes
Jun 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #2, #1385 for context.
This is the RSS generation part, building on PR #1930. It contains the logic for generating RSS