Replace incomplete module markers#14030
Merged
srittau merged 3 commits intopython:mainfrom May 13, 2025
Merged
Conversation
Collaborator
Author
|
For reference, #9548 removed the mentions of incomplete modules from CONTRIBUTING. Since the advent of stubgen, I don't expect many new instances to show up. |
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Avasam
approved these changes
May 12, 2025
Collaborator
Avasam
left a comment
Avasam
left a comment
There was a problem hiding this comment.
I like the # incomplete module comment instead of just # incomplete
It's also nice to see only a few changes in pyrightconfig.stricter.json.
mmingyu
pushed a commit
to mmingyu/typeshed
that referenced
this pull request
May 16, 2025
tsibley
added a commit
to nextstrain/cli
that referenced
this pull request
May 23, 2025
An included typeshed stub update¹ for docutils (and many other modules) meant that docutils.readers.standalone.Reader became an unknown type and was duly reported as such. We don't care. An apparent regression² results in unnecessary "# type: …" comments in the typeshed itself's internal code being reported as our problem. It is not. Ignore them. ¹ <python/typeshed#13765> <python/typeshed#14030> ² <microsoft/pyright#10487>
tsibley
added a commit
to nextstrain/cli
that referenced
this pull request
May 23, 2025
An included typeshed stub update¹ for docutils (and many other modules) meant that docutils.readers.standalone.Reader became an unknown type and was duly reported as such. We don't care. An apparent regression² results in unnecessary "# type: …" comments in the typeshed itself's internal code being reported as our problem. It is not. Ignore them. Note that in this case of ignoring out-of-project source, matching an absolute path seems to be required for the Pyright "ignore" pattern to actually work. (I found no relative or partial paths that work.) Also note that whatever globbing Pyright is doing will not match a leading "**" to an absolute path. Give up and anchor the pattern to an absolute root separately for POSIX and Windows. Yay. ¹ <python/typeshed#13765> <python/typeshed#14030> ² <microsoft/pyright#10487>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #13765