Remove checks for None on assignement for opt args#1600
Merged
Conversation
Member
|
workflow fails on py3.5 & py3.7 on windows. need to investigate. |
Member
|
this PR can be moved to milestone 12.4 if fixing the CI will take too long. |
Member
Author
|
Will try to investigate tomorrow |
Member
Author
|
Tests succeed after restart. All I saw was something about set_webhook_info which should be unrelated ... |
tsnoam
approved these changes
Nov 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As pointed out by @jh0ker in the dev-chat, the checks
are not necessary, since
TelegramObject.to_dict()ignoresNoneanyway.Also Closes #1594