API 7.3 Chat Backgrounds and new params#4247
Merged
Bibo-Joshi merged 13 commits intopython-telegram-bot:api-7.3-centralfrom May 11, 2024
Merged
API 7.3 Chat Backgrounds and new params#4247Bibo-Joshi merged 13 commits intopython-telegram-bot:api-7.3-centralfrom
Bibo-Joshi merged 13 commits intopython-telegram-bot:api-7.3-centralfrom
Conversation
- [x] Added the field via_join_request to the class ChatMemberUpdated.
- [x] Added the parameter live_period to the method editMessageLiveLocation.
- [x] Added the classes `ChatBackground`, `BackgroundType`, `BackgroundFill` and the field `chat_background_set` of type `ChatBackground` to the class Message, describing service messages about background changes
Bibo-Joshi
requested changes
May 9, 2024
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Thank you very much for the nice PR! I've added a few comments
Member
Author
|
Thanks for reviewing! Addressed comments. |
Merged
Bibo-Joshi
reviewed
May 10, 2024
Member
Bibo-Joshi
left a comment
There was a problem hiding this comment.
Thanks for the fast updates - just one new comment :)
* sort constants.__all__ * properly annotate `self.colors = parse_sequence_arg(..)`
please pass V
Member
|
Thank you very much for the helpful PR 👏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4236
Describe the solution you'd like
Added the field question_entities to the class PollAdded the field text_entities to the class PollOptionAdded the parameters question_parse_mode and question_entities to the method sendPollCheck-list for PRs
.. versionadded:: NEXT.VERSION,.. versionchanged:: NEXT.VERSIONor.. deprecated:: NEXT.VERSIONto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)CSI standard <https://standards.mousepawmedia.com/en/stable/csi.html>__AUTHORS.rst(optional)__all__sStability Policy <https://docs.python-telegram-bot.org/stability_policy.html>_ in case of deprecations or changes to documented behaviorIf the PR contains API changes (otherwise, you can ignore this passage)
Checked the Bot API
Stability Policy <https://docs.python-telegram-bot.org/stability_policy.html>_see here <https://docs.python-telegram-bot.org/en/stable/stability_policy.html#case-2>_)self._id_attrsand corresponding documentation__init__acceptsapi_kwargsas kw-only~telegram.Chat& :class:~telegram.Userfor all methods that acceptchat/user_id~telegram.Messagefor all methods that acceptchat_idandmessage_id~telegram.Messageshortcuts: Addedquoteargument if methods acceptsreply_to_message_id~telegram.CallbackQueryfor all methods that accept eitherchat_idandmessage_idorinline_message_idtelegram.constantsand shortcuts to them as class variablestelegram.Message.effective_attachment~telegram.ext.ConversationHandler_extbot.pybot_methods.rstREADME.rstandREADME_RAW.rst(including the badge), as well astelegram.constants.BOT_API_VERSION_INFOtelegram.ext.ExtBotfor new methods that either accept areply_markupin some form or have a return type that is/contains :class:~telegram.Message