Skip to content

Require sample identifiers to start with 5 alphanumeric characters#178

Merged
sven1103 merged 3 commits intomainfrom
fix/restrict-sample-ids
Jul 11, 2024
Merged

Require sample identifiers to start with 5 alphanumeric characters#178
sven1103 merged 3 commits intomainfrom
fix/restrict-sample-ids

Conversation

@KochTobi
Copy link
Contributor

No description provided.

@KochTobi KochTobi requested a review from a team July 10, 2024 09:36
@github-actions github-actions bot added the fix label Jul 10, 2024
@KochTobi KochTobi requested review from sven1103 and removed request for sven1103 July 10, 2024 09:43
Copy link
Contributor

@sven1103 sven1103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor requests, but I think they are important for the readability of the source code.

Copy link
Contributor

@sven1103 sven1103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement!

@sven1103 sven1103 merged commit 39fd2c8 into main Jul 11, 2024
@sven1103 sven1103 deleted the fix/restrict-sample-ids branch July 11, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants