-
Notifications
You must be signed in to change notification settings - Fork 336
Description
Bug report
Describe the bug
QuPath's viewer doesn't (really) support ICC profiles.
This makes the display colors inconsistent with that seen in other viewers, for some file formats.
To Reproduce
Steps to reproduce the behavior:
- Open an SVS image in QuPath
- Compare with the same SVS image opened in ImageScope (with ICC profile turned on)
Expected behavior
QuPath would ideally provide an option to view the image with the ICC profile applied.
This should only affect the viewer; analysis itself should not be impacted.
However, it may be worth considering whether to add an ImageServer implementation that applies an ICC profile as well, since this might potentially be used as a way to do color standardisation (relevant e.g. for deep learning).
If this is done, then the information must be accessible to the viewer so that any embedded ICC profile isn't applied twice.
Screenshots
See https://forum.image.sc/t/color-discrepancy-qupath-x-imagescope-leica-gt450/57948
Desktop (please complete the following information):
- OS: All
- QuPath Version: all until v0.3.2 (current)
Additional context
For further discussion, see https://forum.image.sc/t/color-discrepancy-qupath-x-imagescope-leica-gt450/57948
There is some experimental (and hidden) support for ICC profiles accessible in QuPath via scripting, e.g. see https://github.com/qupath/qupath/blob/main/qupath-gui-fx/src/main/java/qupath/lib/gui/viewer/QuPathViewer.java#L2178
However, performance is really poor and it is not really usable at this time.
Any implementation should be considered alongside gamma adjustment, see #981