Create thresholder window height issue#2003
Merged
petebankhead merged 1 commit intoqupath:mainfrom Sep 30, 2025
Merged
Conversation
Member
|
Looks fine to me - behaviour remains ok on the Mac. It's possible to resize the dialog too big but... well... no one makes anyone do that. On an affected system, does this cause the dialog to open with the buttons visible? Or does it only make it possible to see them by resizing the window, but they are still cropped initially? Also pinging @alanocallaghan who I think introduced the max size limit initially in 50c044b |
Contributor
|
Ah, yeah, interesting. Weird that the required size is so different across platforms. In an ideal world I'd love to not be able to do stupid stuff with windows like make them massive or tiny for no reason, but that seems high effort |
Contributor
|
Do you have font size or perhaps some scaling set to something non-standard? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in issue #2000, the windows height was restricted and prevented access to key buttons.
This PR removes the max height and width for this window to match the behaviour used by other similar windows throughout QuPath.