Skip to content

Removal of separator within right click menu#2006

Merged
petebankhead merged 3 commits intoqupath:mainfrom
finglis:Project-menu-separator
Oct 3, 2025
Merged

Removal of separator within right click menu#2006
petebankhead merged 3 commits intoqupath:mainfrom
finglis:Project-menu-separator

Conversation

@finglis
Copy link
Contributor

@finglis finglis commented Oct 1, 2025

Addresses #2001

@finglis finglis marked this pull request as ready for review October 1, 2025 14:41
@petebankhead petebankhead added this to the v0.7.0 milestone Oct 3, 2025
@petebankhead petebankhead merged commit 939d95d into qupath:main Oct 3, 2025
0 of 6 checks passed
@alanocallaghan
Copy link
Contributor

When a PR completely solves a problem described in an issue, you should use one of the keywords described here in the PR description and/or in the commit message merged to main:

https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

eg, "Resolve #XX". This will automagically close the linked issue

"Addresses" here just created a "finglis mentioned this issue" link from issue 2001 to here.

@petebankhead
Copy link
Member

Ah yes, I use 'fixes' and am generally pleased when it works - had never seen the list of possible keywords.

('Addresses' is still good for when you don't want the issue to close automatically though... since I'm not sure what 'Partially fixes' would end up doing)

@alanocallaghan
Copy link
Contributor

alanocallaghan commented Oct 3, 2025

It's a fairly dumb regex, so even "does not fix" will probably close the issue. Yes, I prefer "addresses" or "relates to" when the issue will linger on, although any mention will link the issue

technically speaking commit messages should be imperative, so one would prefer "resolve" over "resolves" although I find it more intuitive to use the indefinite present (?) form of "resolves"

@finglis finglis deleted the Project-menu-separator branch October 3, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants