Update OpenCV/JavaCPP, reduce warnings#2017
Merged
petebankhead merged 2 commits intoqupath:mainfrom Oct 24, 2025
Merged
Conversation
Update to use OpenCV 4.11.0 and JavaCPP 1.5.12. This removes a warning on launch about JavaCPP versions being inconsistent (caused by TensorFlow pulling in a more recent JavaCPP version than we were using for OpenCV). Also, remove use of `Gson.setLenient()` to remove more startup warnings. Finally, update `QP.getCurrentServer()` to return `ImageServer<BufferedImage>` instead of `ImageServer<?>`. This didn't cause warnings on startup, but it could cause annoyances when trying to write scripts in an IDE.
This was failing on Windows, but passing on macOS. The OpenCV docs suggest that meanStdDev should not be used for more than 4 channels; that didn't appear to be related to the problem that caused the failing tests, but now we extract channels anyway to try to ensure the results are reliable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to use OpenCV 4.11.0 and JavaCPP 1.5.12.
This removes a warning on launch about JavaCPP versions being inconsistent (caused by TensorFlow pulling in a more recent JavaCPP version than we were using for OpenCV).
Also, remove use of
Gson.setLenient()to remove more startup warnings.Finally, update
QP.getCurrentServer()to returnImageServer<BufferedImage>instead ofImageServer<?>. This didn't cause warnings on startup, but it could cause annoyances when trying to write scripts in an IDE.