Log at warn only if all supports failed#2036
Merged
petebankhead merged 2 commits intoqupath:mainfrom Nov 10, 2025
Merged
Conversation
Member
|
Looks fine to me, although I can't figure out a way to have it called - any suggestions? Seems safe enough to just merge, but I haven't been able to check what is actually logged. When I attempt to open a .czi image on my Apple Silicon Mac it's travelling down some other code path, so I don't see how the output from this looks. |
Contributor
Author
|
I ran into it by declaring an image server that claims to have top tier support for czi files but doesn't actually work 🙈 I'll retest that and report back |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From discussion in #2035. This improves the logging for image server providers, only warning if no supported servers can open and then warn logging all exceptions encountered, and debug logging exceptions in the normal case, where advanced users/developers may want to view the exceptions but in normal use they are irrelevant.