Change DEBUG to WARN log level when no primary selected object#2044
Merged
petebankhead merged 1 commit intoqupath:mainfrom Dec 2, 2025
Merged
Change DEBUG to WARN log level when no primary selected object#2044petebankhead merged 1 commit intoqupath:mainfrom
petebankhead merged 1 commit intoqupath:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This script doesn't work:
This is because there is a concept of "primary" selected object in the hierarchy:
selectObjectsByClassification("Tumour")select all objects with theTumourpathclass, but doesn't set the primary selected object.def roi = getSelectedROI()try to get the primary selected object. It doesn't exist, so roi is null.This is not fundamentally a QuPath problem, because functions like
selectObjectsBy...()should be followed bygetSelectedObjects(), notgetSelectedROI()orgetSelectedObject(). However, this behaviour could be more explicit. Currently,getSelectedROI()is able to detect this specific situation and logs a message, but only with theDEBUGlevel. This PR converts it to aWARNmessage.