Ensure pending tile requests are cleared#2048
Merged
petebankhead merged 1 commit intoqupath:mainfrom Dec 10, 2025
Merged
Conversation
This was causing a problem whenever pixel classification overlays were stopped in the midst of life prediction: tiles might not be read, and then the exception was retained and returned on every later attempt to access the same tile. This moves `pendingTiles.remove` to a `finally` block to ensure it is run. It's possible this causes some issues if a tile really *is* invalid though, so we may need to retain exceptions in some cases - rather than repeatedly making the same (doomed) requests. Still, this change is necessary to avoid failures in perfectly normal circumstances.
petebankhead
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was causing a problem whenever pixel classification overlays were stopped in the midst of live prediction: tiles might not be read, and then the exception was retained and returned on every later attempt to access the same tile.
This moves
pendingTiles.removeto afinallyblock to ensure it is run.It's possible this causes some issues if a tile really is invalid though, so we may need to retain exceptions in some cases - rather than repeatedly making the same (doomed) requests.
Still, this change is necessary to avoid failures in perfectly normal circumstances.