Fix bug where threshold lines were added twice#2062
Merged
petebankhead merged 1 commit intoqupath:mainfrom Jan 8, 2026
Merged
Conversation
petebankhead
approved these changes
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR, calling
ChartThresholdPane.addThreshold()was adding a threshold line twice, because:addThreshold(final ObservableNumberValue d, final Color color)was adding a first line.addThreshold(final ObservableNumberValue d, final Color color),thresholds.add(d);is called. This triggershandleLineListChange()to be called.handleLineListChange()callsaddThreshold(ObservableNumberValue), which callsaddThreshold(final ObservableNumberValue d, final Color color): this adds the second line.This PR fixes that by only creating the line in
handleLineListChange(). TheaddThreshold()functions now just updatethresholds(which triggershandleLineListChange()).