Improve project entry filtering#2071
Merged
petebankhead merged 4 commits intoqupath:mainfrom Jan 19, 2026
Merged
Conversation
Made ProjectEntryPredicate package private because it isn't obviously useful anywhere else - and may need to be changed again.
This is active *only* if the regex button is turned off.
Rylern
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to replace #2058 by adding metadata filtering support to the project tab, similar to how it works when using Run for project.
This makes it easier to filter the contents of the project tab to display only the images of interest.
A complication is that Run for project has a simple
TextField, whereas the filter at the bottom of the project table uses aPredicateTextFieldwith regex support. The use of regex isn't compatible with the simple filter syntax ofimage_name_contents|metadata=value.The goal of this PR is to try to achieve the desired functionality while keeping changes and complexity low.
The main changes here:
ProjectEntryPredicateso it's easier to maintain and updateProjectEntryPredicatewhen regex is not selected and continue to use only the image name if the regex button is selected|has_data=trueor|has_data=false(which would help with this forum topic)The fact that the regex toggle now servers two purposes - turning on regex support and turning off metadata search - is a bit unsatisfying, but I think it should at least provide the flexibility that is needed:
Since the use of metadata in projects is still a bit of a 'power user' feature, I expect that most users will be unaffected by the change.
Any thoughts? @zindy @alanocallaghan @Rylern