fix: describe module autoloading in config.ru#1976
Conversation
jeremyevans
left a comment
jeremyevans
left a comment
There was a problem hiding this comment.
Note that the same behavior was true in Rack 2 (need to require 'rack' to get autoloading), it just wasn't necessarily safe in Rack 2 to require specific components, since the components didn't specify their dependencies (nor were there tests for requiring specific components). I think that the difference is that the extracted rackup gem only loads the parts of rack that it needs, while in Rack 2, rackup does require 'rack'.
If you are using a separate server (puma/unicorn/falcon/etc.), I don't think there is a difference in behavior. As that is the vast majority of production usage, this documentation should be specific that it only applies to rackup, and moved to the section that discusses rackup.
|
@jeremyevans Thank you for your review. To follow your review, I move module autoloading section into |
|
This is really great, thanks for pointing out the issue here and making a PR to improve the documentation. |
3 participants
It seems to me that described at #1975 is not well documented.