Fix require in generated bin/rails with --skip-active-job#47014
Merged
jonathanhefner merged 1 commit intorails:mainfrom Jan 15, 2023
Merged
Fix require in generated bin/rails with --skip-active-job#47014jonathanhefner merged 1 commit intorails:mainfrom
bin/rails with --skip-active-job#47014jonathanhefner merged 1 commit intorails:mainfrom
Conversation
Previously `active_job/railtie` was always required even when the plugin was generated with the `--skip-active-job` option. This fix ensures the require is commented out when `active_job` is not used. Also updates a test that checks `bin/rails` with various skip options.
Member
|
Thank you, @stevegeek! 🎉 Backported to |
Contributor
Author
|
Thanks @jonathanhefner, I also saw #47015, nice refactor of this! |
jonathanhefner
added a commit
that referenced
this pull request
Jan 24, 2023
Fix require in generated `bin/rails` with `--skip-active-job` (cherry picked from commit 5b427f9)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Previously
active_job/railtiewas always required in a plugin'sbin/railseven when the plugin was generated with the--skip-active-joboption.This fix ensures the require is commented out when
active_jobis not used.Also updates a test that checks
bin/railswith various skip options.Detail
This Pull Request changes
railties/lib/rails/generators/rails/plugin/templates/bin/rails.ttto comment out theactive_jobrequire when it has been skipped.The
--skip-active-joboption was introduced in this PR where the app generator files where updated but not the pluginbin/railstemplate.Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]This is my first contribution to Rails so please do let me know if anything else is needed. Thanks!