Skip to content

Upload wheel to latest folder in S3#1606

Merged
robertnishihara merged 1 commit intoray-project:masterfrom
richardliaw:Travis_Latest
Feb 26, 2018
Merged

Upload wheel to latest folder in S3#1606
robertnishihara merged 1 commit intoray-project:masterfrom
richardliaw:Travis_Latest

Conversation

@richardliaw
Copy link
Contributor

What do these changes do?

Augments S3 to also upload the commit build to latest. This will resolve an autoscaler problem in 0.3.1 where the config validation is not forward compatible.

Related issue number

#1600

- master
on:
repo: ray-project/ray
condition: $LINUX_WHEELS = 1 || $MAC_WHEELS = 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing from lines 149-163 changed, right? I'm confused by the way the diff is presented.

Also, the stuff below is an exact copy of the stuff above, just with a different upload-dir, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a 2 space increment to make it a list, hence nothing being changed. Yeah second copy is just a different upload-dir.

I followed instructions here - https://docs.travis-ci.com/user/deployment/s3/#Deploy-to-Multiple-Buckets%3A

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, it's technically the same bucket but just multiple folders, right? should still work

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/3956/
Test PASSed.

@robertnishihara robertnishihara merged commit aefefcb into ray-project:master Feb 26, 2018
@robertnishihara robertnishihara deleted the Travis_Latest branch February 26, 2018 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants