[Ray Data | Docs] Error in ray.data.groupby example in docs by jpatra72 · Pull Request #57036 · ray-project/ray

jpatra72 · 2025-09-30T12:35:41Z

Why are these changes needed?

group.drop used in normalize_variety requires the columns arg specified since by default the drop axis is 0 in pandas

Checks

I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
I've run scripts/format.sh to lint the changes in this PR.
I've included any doc changes needed for https://docs.ray.io/en/master/.
- I've added any new APIs to the API Reference. For example, if I added a
  method in Tune, I've added it in doc/source/tune/api/ under the
  corresponding .rst file.
I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
Testing Strategy
- Unit tests
- Release tests
- This PR is not tested :(

Note

Corrects the groupby example to use group.drop(columns=["variety"]) for pandas compatibility.

^{Written by Cursor Bugbot for commit 175837f. This will update automatically on new commits. Configure here.}

`group.drop` used in `normalize_variety`requires either the `columns` arg specified since by default the drop axis is 0. Signed-off-by: jpatra72 <[email protected]>

gemini-code-assist

Code Review

This pull request correctly fixes a bug in the groupby docstring example by specifying the columns argument in pd.DataFrame.drop. I've added a suggestion to further improve the example by using a more performant and robust vectorized implementation for the normalization logic, which also handles the edge case of division by zero.

gemini-code-assist · 2025-09-30T12:38:40Z

python/ray/data/dataset.py

+                    for feature in group.drop(columns=["variety"]).columns:
                        group[feature] = group[feature] / group[feature].abs().max()


This implementation can be improved for performance and robustness. Iterating over DataFrame columns is generally less efficient than using vectorized operations. Additionally, if a feature column contains only zeros, group[feature].abs().max() will be 0, leading to division by zero.

A more idiomatic and robust pandas implementation would be to perform this normalization using vectorized operations and handle the division-by-zero edge case.

Suggested change

for feature in group.drop(columns=["variety"]).columns:

group[feature] = group[feature] / group[feature].abs().max()

features_to_normalize = group.columns.drop("variety")

max_abs_values = group[features_to_normalize].abs().max()

# Avoid division by zero for columns that are all zeros.

max_abs_values[max_abs_values == 0] = 1

group[features_to_normalize] = group[features_to_normalize] / max_abs_values

…ect#57036) ## Why are these changes needed? `group.drop` used in `normalize_variety` requires the `columns` arg specified since by default the drop axis is 0 in pandas ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :(  --- > [!NOTE] > Corrects the groupby example to use group.drop(columns=["variety"]) for pandas compatibility. > > Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 175837f. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).  Signed-off-by: jpatra72 <[email protected]> Signed-off-by: Seiji Eicher <[email protected]>

## Why are these changes needed? `group.drop` used in `normalize_variety` requires the `columns` arg specified since by default the drop axis is 0 in pandas ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :(  --- > [!NOTE] > Corrects the groupby example to use group.drop(columns=["variety"]) for pandas compatibility. > > Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 175837f. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).  Signed-off-by: jpatra72 <[email protected]> Signed-off-by: Douglas Strodtman <[email protected]>

…ect#57036) ## Why are these changes needed? `group.drop` used in `normalize_variety` requires the `columns` arg specified since by default the drop axis is 0 in pandas ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :(  --- > [!NOTE] > Corrects the groupby example to use group.drop(columns=["variety"]) for pandas compatibility. > > Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 175837f. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).  Signed-off-by: jpatra72 <[email protected]>

…ect#57036) ## Why are these changes needed? `group.drop` used in `normalize_variety` requires the `columns` arg specified since by default the drop axis is 0 in pandas ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :(  --- > [!NOTE] > Corrects the groupby example to use group.drop(columns=["variety"]) for pandas compatibility. > > Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 175837f. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).  Signed-off-by: jpatra72 <[email protected]> Signed-off-by: Josh Kodi <[email protected]>

…ect#57036) ## Why are these changes needed? `group.drop` used in `normalize_variety` requires the `columns` arg specified since by default the drop axis is 0 in pandas ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :(  --- > [!NOTE] > Corrects the groupby example to use group.drop(columns=["variety"]) for pandas compatibility. > > Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 175837f. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).  Signed-off-by: jpatra72 <[email protected]>

…ect#57036) ## Why are these changes needed? `group.drop` used in `normalize_variety` requires the `columns` arg specified since by default the drop axis is 0 in pandas ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :(  --- > [!NOTE] > Corrects the groupby example to use group.drop(columns=["variety"]) for pandas compatibility. > > Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 175837f. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).  Signed-off-by: jpatra72 <[email protected]> Signed-off-by: Aydin Abiar <[email protected]>

…ect#57036) ## Why are these changes needed? `group.drop` used in `normalize_variety` requires the `columns` arg specified since by default the drop axis is 0 in pandas ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :(  --- > [!NOTE] > Corrects the groupby example to use group.drop(columns=["variety"]) for pandas compatibility. > > Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 175837f. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).  Signed-off-by: jpatra72 <[email protected]> Signed-off-by: Future-Outlier <[email protected]>

[Ray Data | Docs] Mistake in ray.data.groupby example

175837f

`group.drop` used in `normalize_variety`requires either the `columns` arg specified since by default the drop axis is 0. Signed-off-by: jpatra72 <[email protected]>

jpatra72 requested a review from a team as a code owner September 30, 2025 12:35

gemini-code-assist bot reviewed Sep 30, 2025

View reviewed changes

jpatra72 changed the title ~~[Ray Data | Docs] Mistake in ray.data.groupby example~~ [Ray Data | Docs] Error in ray.data.groupby example in docs Sep 30, 2025

ray-gardener bot added docs An issue or change related to documentation data Ray Data-related issues labels Sep 30, 2025

goutamvenkat-anyscale approved these changes Sep 30, 2025

View reviewed changes

goutamvenkat-anyscale added the go add ONLY when ready to merge, run all tests label Sep 30, 2025

richardliaw merged commit 5ae0b3b into ray-project:master Oct 1, 2025
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Ray Data | Docs] Error in ray.data.groupby example in docs#57036

[Ray Data | Docs] Error in ray.data.groupby example in docs#57036
richardliaw merged 1 commit intoray-project:masterfrom
jpatra72:patch-2

jpatra72 commented Sep 30, 2025 •

edited by cursor bot

Loading

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Sep 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		for feature in group.drop(columns=["variety"]).columns:
		group[feature] = group[feature] / group[feature].abs().max()

-                    for feature in group.drop(columns=["variety"]).columns:
-                        group[feature] = group[feature] / group[feature].abs().max()
+                    features_to_normalize = group.columns.drop("variety")
+                    max_abs_values = group[features_to_normalize].abs().max()
+                    # Avoid division by zero for columns that are all zeros.
+                    max_abs_values[max_abs_values == 0] = 1
+                    group[features_to_normalize] = group[features_to_normalize] / max_abs_values

Conversation

jpatra72 commented Sep 30, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why are these changes needed?

Checks

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jpatra72 commented Sep 30, 2025 •

edited by cursor bot

Loading