[Train] Isolating Ray Train Circular Dependency Tests #57710
Merged
matthewdeng merged 3 commits intoray-project:masterfrom Oct 17, 2025
Merged
[Train] Isolating Ray Train Circular Dependency Tests #57710matthewdeng merged 3 commits intoray-project:masterfrom
matthewdeng merged 3 commits intoray-project:masterfrom
Conversation
Signed-off-by: JasonLi1909 <[email protected]>
![gemini-code-assist[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This PR introduces a robust way to test for circular dependencies by isolating each import in a separate subprocess. This is a great improvement to the test suite's reliability. My review focuses on further enhancing the test structure by using pytest's parameterization feature, which will make the tests more readable, maintainable, and provide more granular feedback on failures.
![cursor[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Signed-off-by: JasonLi1909 <[email protected]>
JasonLi1909
force-pushed
the
isolate-circular-dependency-tests
branch
from
05798d8 to
7cfe22d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
justinyeh1995
pushed a commit
to justinyeh1995/ray
that referenced
this pull request
Oct 20, 2025
) This PR updates Ray Train's circular dependency tests to isolate each import statement in the test within a separate subprocess. This is because each import has the side effect of mutating `sys.modules` which can cause other imports to pass when they could have failed in an isolated subprocess. --------- Signed-off-by: JasonLi1909 <[email protected]>
xinyuangui2
pushed a commit
to xinyuangui2/ray
that referenced
this pull request
Oct 22, 2025
) This PR updates Ray Train's circular dependency tests to isolate each import statement in the test within a separate subprocess. This is because each import has the side effect of mutating `sys.modules` which can cause other imports to pass when they could have failed in an isolated subprocess. --------- Signed-off-by: JasonLi1909 <[email protected]> Signed-off-by: xgui <[email protected]>
elliot-barn
pushed a commit
that referenced
this pull request
Oct 23, 2025
This PR updates Ray Train's circular dependency tests to isolate each import statement in the test within a separate subprocess. This is because each import has the side effect of mutating `sys.modules` which can cause other imports to pass when they could have failed in an isolated subprocess. --------- Signed-off-by: JasonLi1909 <[email protected]> Signed-off-by: elliot-barn <[email protected]>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
) This PR updates Ray Train's circular dependency tests to isolate each import statement in the test within a separate subprocess. This is because each import has the side effect of mutating `sys.modules` which can cause other imports to pass when they could have failed in an isolated subprocess. --------- Signed-off-by: JasonLi1909 <[email protected]>
Aydin-ab
pushed a commit
to Aydin-ab/ray-aydin
that referenced
this pull request
Nov 19, 2025
) This PR updates Ray Train's circular dependency tests to isolate each import statement in the test within a separate subprocess. This is because each import has the side effect of mutating `sys.modules` which can cause other imports to pass when they could have failed in an isolated subprocess. --------- Signed-off-by: JasonLi1909 <[email protected]> Signed-off-by: Aydin Abiar <[email protected]>
Future-Outlier
pushed a commit
to Future-Outlier/ray
that referenced
this pull request
Dec 7, 2025
) This PR updates Ray Train's circular dependency tests to isolate each import statement in the test within a separate subprocess. This is because each import has the side effect of mutating `sys.modules` which can cause other imports to pass when they could have failed in an isolated subprocess. --------- Signed-off-by: JasonLi1909 <[email protected]> Signed-off-by: Future-Outlier <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates Ray Train's circular dependency tests to isolate each import statement in the test within a separate subprocess. This is because each import has the side effect of mutating
sys.moduleswhich can cause other imports to pass when they could have failed in an isolated subprocess.