[Train] [doc] Local mode user guide#57751
Conversation
Signed-off-by: xgui <[email protected]>
Signed-off-by: xgui <[email protected]>
There was a problem hiding this comment.
Code Review
This pull request adds a user guide for local mode in Ray Train. The documentation is well-written and provides clear examples for single-process, multi-process (with torchrun), and testing scenarios. I've made a couple of minor suggestions to improve clarity and fix a style issue in the new documentation file.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Xinyuan <[email protected]>
Signed-off-by: xgui <[email protected]>
Signed-off-by: xgui <[email protected]>
TimothySeah
left a comment
There was a problem hiding this comment.
Generally LGTM with some suggestions
| Ray Train automatically detects the torchrun environment variables and configures the distributed | ||
| training accordingly. You can access distributed training information through :func:`ray.train.get_context()`: | ||
|
|
||
| .. testcode:: |
There was a problem hiding this comment.
Consider moving this to a separate section that describes the behavior of various ray.train functions in local mode
There was a problem hiding this comment.
I added one section at the end to list the different behaviors.
Co-authored-by: Timothy Seah <[email protected]> Signed-off-by: Xinyuan <[email protected]>
Co-authored-by: Timothy Seah <[email protected]> Signed-off-by: Xinyuan <[email protected]>
Co-authored-by: Timothy Seah <[email protected]> Signed-off-by: Xinyuan <[email protected]>
Co-authored-by: Timothy Seah <[email protected]> Signed-off-by: Xinyuan <[email protected]>
Co-authored-by: Timothy Seah <[email protected]> Signed-off-by: Xinyuan <[email protected]>
Co-authored-by: Timothy Seah <[email protected]> Signed-off-by: Xinyuan <[email protected]>
Co-authored-by: Timothy Seah <[email protected]> Signed-off-by: Xinyuan <[email protected]>
Signed-off-by: xgui <[email protected]>
Signed-off-by: xgui <[email protected]>
matthewdeng
left a comment
There was a problem hiding this comment.
Love this user guide! Mostly made some suggestions around reorganization of the existing content for better flow.
Co-authored-by: matthewdeng <[email protected]> Signed-off-by: Xinyuan <[email protected]>
Co-authored-by: matthewdeng <[email protected]> Signed-off-by: Xinyuan <[email protected]>
Co-authored-by: matthewdeng <[email protected]> Signed-off-by: Xinyuan <[email protected]>
Signed-off-by: xgui <[email protected]>
Signed-off-by: xgui <[email protected]>
User guide for local mode. --------- Signed-off-by: xgui <[email protected]> Signed-off-by: Xinyuan <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Timothy Seah <[email protected]> Co-authored-by: matthewdeng <[email protected]>
User guide for local mode. --------- Signed-off-by: xgui <[email protected]> Signed-off-by: Xinyuan <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Timothy Seah <[email protected]> Co-authored-by: matthewdeng <[email protected]>
User guide for local mode. --------- Signed-off-by: xgui <[email protected]> Signed-off-by: Xinyuan <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Timothy Seah <[email protected]> Co-authored-by: matthewdeng <[email protected]> Signed-off-by: Aydin Abiar <[email protected]>
User guide for local mode. --------- Signed-off-by: xgui <[email protected]> Signed-off-by: Xinyuan <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Timothy Seah <[email protected]> Co-authored-by: matthewdeng <[email protected]> Signed-off-by: Future-Outlier <[email protected]>
User guide for local mode. --------- Signed-off-by: xgui <[email protected]> Signed-off-by: Xinyuan <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Timothy Seah <[email protected]> Co-authored-by: matthewdeng <[email protected]> Signed-off-by: peterxcli <[email protected]>
Description
User guide for local mode.
Related issues
Types of change
Checklist
Does this PR introduce breaking changes?
Testing:
Code Quality:
git commit -s)Documentation:
doc/source/(if applicable)Additional context