[train] Migrate/disable a few remaining tests for V2#57764
Merged
justinvyu merged 17 commits intoray-project:masterfrom Oct 17, 2025
Merged
[train] Migrate/disable a few remaining tests for V2#57764justinvyu merged 17 commits intoray-project:masterfrom
justinvyu merged 17 commits intoray-project:masterfrom
Conversation
Signed-off-by: Justin Yu <[email protected]>
![gemini-code-assist[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enables Ray Train V2 by default, a significant but intentional breaking change. The implementation is a simple and correct one-line modification in is_v2_enabled to change the default value. This aligns with the project's goal of migrating users to Train V2 while providing an escape hatch (RAY_TRAIN_V2_ENABLED=0) for those who need to remain on the deprecated V1. Based on the PR description that all related tests and examples have been migrated, the change appears sound.
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
justinvyu
commented
Oct 16, 2025
Contributor
Author
justinvyu
left a comment
justinvyu
left a comment
There was a problem hiding this comment.
I missed a few test suites (train doc test and train gpu py_doctest), so will do that in a followup.
justinvyu
changed the title
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
justinvyu
commented
Oct 16, 2025
Signed-off-by: Justin Yu <[email protected]>
aslonnie
approved these changes
Oct 17, 2025
Signed-off-by: Justin Yu <[email protected]>
kamil-kaczmarek
approved these changes
Oct 17, 2025
justinyeh1995
pushed a commit
to justinyeh1995/ray
that referenced
this pull request
Oct 20, 2025
There's a few more tests that haven't been migrated -- this PR migrates them as preparation to flip the V2 switch. --------- Signed-off-by: Justin Yu <[email protected]>
xinyuangui2
pushed a commit
to xinyuangui2/ray
that referenced
this pull request
Oct 22, 2025
There's a few more tests that haven't been migrated -- this PR migrates them as preparation to flip the V2 switch. --------- Signed-off-by: Justin Yu <[email protected]> Signed-off-by: xgui <[email protected]>
elliot-barn
pushed a commit
that referenced
this pull request
Oct 23, 2025
There's a few more tests that haven't been migrated -- this PR migrates them as preparation to flip the V2 switch. --------- Signed-off-by: Justin Yu <[email protected]> Signed-off-by: elliot-barn <[email protected]>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
There's a few more tests that haven't been migrated -- this PR migrates them as preparation to flip the V2 switch. --------- Signed-off-by: Justin Yu <[email protected]>
Aydin-ab
pushed a commit
to Aydin-ab/ray-aydin
that referenced
this pull request
Nov 19, 2025
There's a few more tests that haven't been migrated -- this PR migrates them as preparation to flip the V2 switch. --------- Signed-off-by: Justin Yu <[email protected]> Signed-off-by: Aydin Abiar <[email protected]>
Future-Outlier
pushed a commit
to Future-Outlier/ray
that referenced
this pull request
Dec 7, 2025
There's a few more tests that haven't been migrated -- this PR migrates them as preparation to flip the V2 switch. --------- Signed-off-by: Justin Yu <[email protected]> Signed-off-by: Future-Outlier <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There's a few more tests that haven't been migrated -- this PR migrates them as preparation to flip the V2 switch.
Related issues
Types of change
Checklist
Does this PR introduce breaking changes?
Testing:
Code Quality:
git commit -s)Documentation:
doc/source/(if applicable)Additional context