[Data] - Fix expression mapping for Pandas#57868
Merged
alexeykudinkin merged 1 commit intoray-project:masterfrom Oct 24, 2025
Merged
[Data] - Fix expression mapping for Pandas#57868alexeykudinkin merged 1 commit intoray-project:masterfrom
alexeykudinkin merged 1 commit intoray-project:masterfrom
Conversation
Signed-off-by: Goutam <[email protected]>
goutamvenkat-anyscale
added
data
![gemini-code-assist[bot]](proxy.php?url=https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses an issue where filter operations for Pandas DataFrames were incorrectly mapped, leading to broken expression evaluation. The changes involve correcting the mapping of IN, NOT_IN, and NOT operations to the appropriate Pandas functions and adding new test cases to ensure the correct behavior of filter operations with both Arrow and Pandas blocks. The review focuses on the correctness and maintainability of the code changes.
goutamvenkat-anyscale
changed the title
bveeramani
approved these changes
Oct 23, 2025
| @@ -271,14 +321,18 @@ def test_filter_with_invalid_expression(ray_start_regular_shared, tmp_path): | |||
| ) | |||
| def test_filter_with_predicate_expressions( | |||
Member
There was a problem hiding this comment.
Out of scope for this PR, but I think if we're going to have like 20+ parametrizations, we should refactor this as a unit test (no ray.init)
xinyuangui2
pushed a commit
to xinyuangui2/ray
that referenced
this pull request
Oct 27, 2025
Signed-off-by: xgui <[email protected]>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
Aydin-ab
pushed a commit
to Aydin-ab/ray-aydin
that referenced
this pull request
Nov 19, 2025
Signed-off-by: Aydin Abiar <[email protected]>
Future-Outlier
pushed a commit
to Future-Outlier/ray
that referenced
this pull request
Dec 7, 2025
Signed-off-by: Future-Outlier <[email protected]>
Blaze-DSP
pushed a commit
to Blaze-DSP/ray
that referenced
this pull request
Dec 18, 2025
peterxcli
pushed a commit
to peterxcli/ray
that referenced
this pull request
Feb 25, 2026
Signed-off-by: peterxcli <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
IN,NOT_INandNOTwere incorrectly mapped to the wrong pandas function which broke expression evaluation for pandas dfs.Related issues
Fixes #57849
Additional information